Is spanking a child an appropriate form of discipline?

Yes

No- It can go too far; promotes ideas of violence and that hitting is ok;

A smack on the hand or butt is ok for toddlers, you should tell them why it is wrong and once a child can communicate in full sentences another form of discipline should be considered